joplin / plugin-kanban

It allows notes in a notebook to be organized in a kanban board.
https://discourse.joplinapp.org/t/kanban-board-project/17469
131 stars 17 forks source link

Fix build #50

Closed personalizedrefrigerator closed 6 months ago

personalizedrefrigerator commented 6 months ago

This pull request updates several dependencies. This should fix build issues reported here.

Specifically, this pull request:

tessus commented 6 months ago

awesome, thanks! I'll merge tomorrow morning.

tessus commented 6 months ago

I tried the PR: removed node_modules and the package lock file, but ran into another error:

npm i
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs

> joplin-plugin-kanban@1.0.7 prepare
> npm run dist

> joplin-plugin-kanban@1.0.7 dist
> webpack --env joplin-plugin-config=buildMain && webpack --env joplin-plugin-config=buildExtraScripts && webpack --env joplin-plugin-config=createArchive

ERROR in /Users/tessus/data/work/plugin-kanban/api/noteListType.ts
3:9-13
[tsl] ERROR in /Users/tessus/data/work/plugin-kanban/api/noteListType.ts(3,10)
      TS2305: Module '"./types"' has no exported member 'Size'.

webpack compiled with 1 error
npm ERR! code 1
npm ERR! path /Users/tessus/data/work/plugin-kanban
npm ERR! command failed
npm ERR! command sh -c npm run dist

npm ERR! A complete log of this run can be found in: /Users/tessus/.npm/_logs/2024-05-16T17_58_22_288Z-debug-0.log

Since you apparently don't get any errors, maybe my env is broken. It's strange though, all the yarn and npm commands work in my Joplin source tree.

personalizedrefrigerator commented 6 months ago
ERROR in /Users/tessus/data/work/plugin-kanban/api/noteListType.ts
3:9-13
[tsl] ERROR in /Users/tessus/data/work/plugin-kanban/api/noteListType.ts(3,10)
     TS2305: Module '"./types"' has no exported member 'Size'. 

On my computer and in git, api/noteListType.ts doesn't exist. Does git status show any untracked files?

tessus commented 6 months ago

Hmm, yes, you are correct. maybe they are a left over from another branch when I tried to do a npm run update.

I deleted them and all is fine. Cheers