Fix Interpretation -> Spectrogram

jopohl / urh

Universal Radio Hacker: Investigate Wireless Protocols Like A Boss

GNU General Public License v3.0

10.99k stars 874 forks source link

Fix Interpretation -> Spectrogram #1018

Closed maennel closed 1 year ago

maennel commented 1 year ago

This change fixes:

opening the spectrogram
applying a band pass filter to the spectrogram to create a new signal

Crashes related to these fixes were observed on the latest release (v2.9.3) and on the master branch.

As these are very isolated fixes "to make it work", there might be an underlying issue as to why they appeared in the first place. I can only speculate about the root cause (maybe pinning versions of dependencies could help), but I'll leave a more in-depth analysis to the experts.

Cheers, I hope this helps.

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

andynoack commented 1 year ago

Thank you for providing your solution! Actually there is already a PR to fix this bug, so we close here. Many thanks anyway!

maennel commented 1 year ago

Thanks for the heads-up @andynoack - it's true that I haven't spent much time to research whether there's a different PR/issue open already.

andynoack commented 1 year ago

Yes, it is also my bad, because the title of the other PR is not very suitable. :)