jopohl / urh

Universal Radio Hacker: Investigate Wireless Protocols Like A Boss
GNU General Public License v3.0
10.85k stars 862 forks source link

Incorrect ASCII conversion for LSD/LE byte order #1098

Open nosejam opened 8 months ago

nosejam commented 8 months ago
Expected Behavior

My data in hex format in the the analysis view in MSB/BE format is 13 53 63 13 a4. I know that the ascii data should be 1561J which would be 31 35 36 31 4a in hexadecimal. When I create a label for the data and change the bit/byte order and display in hex it shows 31 35 36 31 4a and I would expect that changing the Display Format to ascii would show 1561J.

Actual Behavior

When LSD/LE is selected, instead of converting 31 35 36 31 4a to 1561J, it converts to Sc¤ which is the ascii conversion of 13 53 63 13 a4 (same as MSB/BE).

Steps To Reproduce
  1. Create a signal with hex digits representing ascii data, but with the least significant digit before the most significant digit.
  2. Create a label for the data
  3. Set the Display format to hex
  4. Set the bit/byte order to LSD/LE and verify that the hex values are arranged in the correct order for the ascii content
  5. Change the Display Format to Ascii and notice that the value is not correct.
Screenshots

image image

Platform Specifications