search

jorabin / KeePassJava2

Java API for KeePass Password Databases - Read/Write 2.x (File versions 3 and 4), Read 1.x
Apache License 2.0
247 stars 69 forks source link

Added Expiration Time Setters #18

Closed AugustNagro closed 6 years ago

AugustNagro commented 6 years ago

See: https://github.com/jorabin/KeePassJava2/pull/17

jorabin commented 6 years ago

Really sorry to be a party pooper on this but don't think that we should have setters for lastAccessTime etc. since those should be automatically maintained by the system - and it's not clear what their semantic is if we say "you can set this to an arbitrary value, possibly in the future".

Actually, it really is not clear what their semantic is, other than how they are used in the original KeePass code, but I think it's reasonable to say that they are intended as "read only" values.

I'll adopt your code but remove those setters, OK?

AugustNagro commented 6 years ago

Removed 😁