ADD Contact Form Section and Footer in the portfolio

joramot / capstone_portfolio

This is my first project where I use the technologies, HTML, CSS and Javascript, it is the portfolio of the apps and projects that I have created during my training in the Microverse program and where I will add the new projects that I will develop and the new technologies that I will learn .

MIT License

4 stars 0 forks source link

ADD Contact Form Section and Footer in the portfolio #4

Closed joramot closed 1 year ago

joramot commented 1 year ago

The tasks to do are:

Add Contact Form Section in index.html.
Add Footer in index.html.
Add CSS classes to the Contact Form
Add CSS classes to the Footer.
Add social media icons in the images folder.

joramot commented 1 year ago

ok @alizaamir123 thanks, I will do it the changes.

joramot commented 1 year ago

hello @Kamba56 my coding partner @alizaamir123 did contributions with her comments https://github.com/joramot/capstone_portfolio/pull/4#pullrequestreview-1361622340 Is not correct?

Kamba56 commented 1 year ago

hello @Kamba56 my coding partner @alizaamir123 did contributions with her comments #4 (review) Is not correct?

Hi @joramot, this is a pair programming project. This means that you and your partner should take turns being the driver and the navigator. The driver should write the code while the navigator makes suggestions. When it's time to switch turns, the driver pushes their changes to github. So commit messages from the parties involved should be visible on the PR. To achieve this, you need to add your partner as a contributor to the repo.

joramot commented 1 year ago

@Kamba56 oooh!!, ok, I understand now, thanks so much @Kamba56 I will do it.

joramot commented 1 year ago

Hello @adel-gu thanks for your time and observations, I will do the corrections in the description of the PR, and complete the peer-to-peer activity with my partners.

joramot commented 1 year ago

@Zuhaib042 @adel-gu @ @Kamba56

I have problems with my partner's commits, I have made three commits and they do not appear in my project and this is holding me back, I am upset because I do not have the necessary help to solve this problem and time is advancing, please can you help me to understand why my partner's commits don't appear?

My partner has already had his project approved and he doesn't have any commits from his coding partners. Why?, and I can't move forward and I already have one commit from one of my coding partners.

Please tell me what can I do?

Thanks.

ABDULALI3468 commented 1 year ago

@joramot It's me ABDUL ALI your Code Reviewer. I understand your problem you did a great job. I am reviewing your Pull request. Just wait for a few minutes. I will get back to you very soon!

joramot commented 1 year ago

@Shisui6 thanks for your time.

adel-gu commented 1 year ago

Hi @joramot 👋🏼, Sorry for the late replay, I gues the issue has been resolved 👍🏼.

Congratulations ✨