search

joranmulderij / flutter_guitar_tabs

BSD 3-Clause "New" or "Revised" License
23 stars 11 forks source link

Where should I get all the tabs data? #4

Closed alexaung closed 2 years ago

alexaung commented 2 years ago

Where should I get all the tabs data? I am using flutter_chord and when user click the chord I want to show the tabs. May I know where can I get all the tabs data?

joranmulderij commented 2 years ago

They don't get provided by the package, but here are some links to projects that do provide them. They might not perfectly align with the api of this package, but making them fit should not be too difficult. I will do an update to support some more diverse input types. I will also add these links to the readme.

Hope this helps you!

alexaung commented 2 years ago

@joranmulderij Thank you so much for json chords and wonderful plugin.

jeremiahlukus commented 2 years ago

@joranmulderij hey would you be opposed to including this data in the package? Then remove the required tab param and add a tuning param. 

FlutterGuitarTab(
  tuning: 'EADGBE'
  name: 'Dm'
  tabName: 'Dm',  // || tab: []
)

so you would have to include either tab or tabName

I was planning on forking and making this change just seeing if you are open to PR's for this.

joranmulderij commented 2 years ago

The reason I'm not doing this is because it would increase the size of the package. Some users might want to dynamically download the tabs. Forcing data into a package is not a good idea.