search

jorchube / monitorets

GNU General Public License v3.0
103 stars 7 forks source link

Keyboard shortcut for settings #59

Closed gregorni closed 1 year ago

gregorni commented 1 year ago

There should be a keyboard shortcut to easily access the preferences window. I would suggest Ctrl+,.

jorchube commented 1 year ago

Hello!

Thank you for opening this issue and the associated Pull Request: It is a very nice one!

I don't know if you have noticed, but the linting check of the PR has failed.

If you don't want to correct it, I can just add the change myself. Otherwise, If you prefer to update your PR running the linter you can do it by configuring a development environment by running

make install-dev-requirements

then entering a shell in that environment

make dev-shell

and then run the linter

make linting

or to just check the linter rules without modifying the code you can run

make check-linting

Or you can do it by any other means you want.

Anyway, let me know if you prefer to update your PR or if I shall apply the changes myself :)

Thank you very much!

gregorni commented 1 year ago

Thanks for the detailed instructions! I fixed it now. The workflows are still pending, so we'll have to see if all checks pass.

Edit: They passed! I think the PR should be ready now.

jorchube commented 1 year ago

The PR is more than ready! :rocket: Thank you very much!