search

jordanbaird / Ice

Powerful menu bar manager for macOS
https://icemenubar.app
GNU General Public License v3.0
10.26k stars 194 forks source link

Rename Brew cask formula to `ice` #54

Closed uncenter closed 2 months ago

uncenter commented 2 months ago

Description

This may not be an option for whatever reason but it would be great if we could rename the cask formula from jordanbaird-ice to just ice. There isn't an existing cask with that name (though there is a regular formula for it, but I think that doesn't matter as I can see other names that have both a CLI and cask attached).

Screenshots

No response

jordanbaird commented 2 months ago

I would prefer it that way, too, but running brew audit on the renamed cask fails with the following:

 - possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/i/ice.rb

Could you point me to some of the duplicate names you mentioned? Maybe they make some exceptions, or maybe it doesn't matter as much as I'm thinking. We could also try asking the Homebrew forum to get a definitive answer.

fastnlight0 commented 2 months ago

How about something simple, such as ice-mac, or ice-menubar, or something that tells what it does?

jordanbaird commented 2 months ago

@fastnlight0 Homebrew's cask documentation states that the name should either be the app name, or the app name prefixed by the vendor name in the case of duplicates, so we only really have two options...unless I'm reading into it too much.

uncenter commented 2 months ago

I would prefer it that way, too, but running brew audit on the renamed cask fails with the following:

 - possible duplicate, cask token conflicts with Homebrew core formula: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/i/ice.rb

Could you point me to some of the duplicate names you mentioned? Maybe they make some exceptions, or maybe it doesn't matter as much as I'm thinking. We could also try asking the Homebrew forum to get a definitive answer.

Hmmm, here's one I found.

Screenshot 2024-04-13 at 07 01 22 (Arc)

uncenter commented 2 months ago

How about something simple, such as ice-mac, or ice-menubar, or something that tells what it does?

I like ice-menubar! No duplicates there either :D

jordanbaird commented 2 months ago

I'll ask over on the forums to see what they think. If they say that either one is fine, which one would we prefer? ice is nice and succinct, but has the downside of having to use the full brew install --cask ice syntax. If we use ice-menubar, it can be shortened to brew install ice-menubar (I say "shortened," but it's actually a bit longer haha).

jordanbaird commented 2 months ago

There's a chance they'll be against the rename altogether, as it may introduce some friction for users