Open umgefahren opened 1 year ago
Overall, looks good to me, if only @jordanbray accepted it...
This looks great and I would love for it to be merged.
However, having a PR (#71) open for almost 2 years now with no feedback, I don't think it ever will.
Would you guys be interested in forking this crate under a new name? There are a few open PRs that we could merge. I would be happy to help but I don't have much Rust experience.
This Pull Request brings the library into the standards and convention of Rust at the time of writing, at least from my point of view.
failure
tothiserror
extern crate foo;
syntaxconst
.I really like this innovative, unconventional use of build.rs, however it also greatly increases build time. It might be possible to replace the build.rs file entirely by clever use of const. It might be even easier, once more operations are available to const.
However the usage of static mut seems unnecessary, but I don't have the time to implement those changes.
On a additional note I think it's sufficient to rely on docs.rs.