search

jordanbyron / react-native-quick-actions

A react-native interface for Touch 3D home screen quick actions
MIT License
1.06k stars 95 forks source link

How to use an icon placed in drawable folder for shortcuts in android? #49

Closed sahil290791 closed 6 years ago

sahil290791 commented 7 years ago

I have currently placed set of icons in drawable folder, but react-native-quick-actions is unable to pick up the icon and it keeps displaying that android logo.

How can I use my own icons?

jordanbyron commented 7 years ago

Doing a quick read of the code it appears you can: https://github.com/madriska/react-native-quick-actions/blob/master/android/src/main/java/com/reactNativeQuickActions/AppShortcutsModule.java#L105-L106

In fact it looks like you can only pull icons from your package, unless I am misunderstanding how those two lines of code work.

aidan-doherty commented 6 years ago

I got it working in the drawable folder just had to rename my icons to make sure they had no uppercase characters or dashes and re install the app would be nice if this was in the documentation.

jordanbyron commented 6 years ago

Can you submit a PR with the updated docs? On Fri, Jan 12, 2018 at 4:50 AM Aidan notifications@github.com wrote:

I got it working in the drawable folder just had to rename my icons to make sure they had no uppercase characters or dashes and re install the app would be nice if this was in the documentation.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jordanbyron/react-native-quick-actions/issues/49#issuecomment-357192703, or mute the thread https://github.com/notifications/unsubscribe-auth/AACe1tX71Yyy3lyFiPX9Vh8uchmirk6Bks5tJyrogaJpZM4P3_BL .

-- Jordan