search

jordanbyron / react-native-quick-actions

A react-native interface for Touch 3D home screen quick actions
MIT License
1.06k stars 95 forks source link

Implement initialGesture #5

Closed grabbou closed 9 years ago

grabbou commented 9 years ago

This pull request implements initial gesture support similar to RCTPushNotificationManager.

jordanbyron commented 9 years ago

Cool stuff @grabbou! Could you update the README to include instructions on how to use the new popInitialGesture method? Once that's done I'll pull this down, test it out, and :shipit:

grabbou commented 9 years ago

Yeah, sure. Currently my Simulator force closes when I open my app with initial gesture, but this is likely iOS problem since using gestures on iOS Simulator is only supported via some fancy hacks. I will let you know on Monday from the office if it works.

grabbou commented 9 years ago

(or if you have iPhone6s real device, give it a go!)

jordanbyron commented 9 years ago

(or if you have iPhone6s real device, give it a go!)

I do! I'll check it out and see if I can get it working on my phone.

grabbou commented 9 years ago

Cool, thanks!

jordanbyron commented 9 years ago

@grabbou I'm seeing the crash on my phone as well. Looks like happens right after the constantsToExport method is called and _initialGesture is not null. Any ideas?

jordanbyron commented 9 years ago

@grabbou https://github.com/jordanbyron/react-native-quick-actions/releases/tag/0.0.3

grabbou commented 9 years ago

I was close! Not that many changes :) Thank you!