search

jordanbyron / react-native-quick-actions

A react-native interface for Touch 3D home screen quick actions
MIT License
1.06k stars 93 forks source link

android:launchMode="singleTop" not receiving quickActionShortcut events #66

Closed JonasWho closed 5 years ago

JonasWho commented 6 years ago

As the docs state, it should be only android:launchMode="standard" that does not receive quickActionShortcut events from DeviceEventEmitter but I'm using singleTop and experiencing the same behaviour. Actually, it seems to be the case on Android no matter what launchmode I choose.

Anybody else experiencing this?

React Native 0.54.4 Device: Samsung Galaxy S8 OS: Android 8.0.0

ItsNoHax commented 6 years ago

I sent a PR to fix this MONTHS ago: https://github.com/jordanbyron/react-native-quick-actions/pull/54

But here we are...

JonasWho commented 6 years ago

@ItsNoHax thanks, maybe I'll jump on over to your fork then, or have you changed other stuff dramatically?

ItsNoHax commented 6 years ago

Just make sure you use the correct branch: saveUserInfoAndroid! And I didn't alter any thing else, we use it for a production app.

JonasWho commented 5 years ago

@jordanbyron what's up with this, I can see that a new version came out since I filed this issue. Have you not been able to reproduce it?

jordanbyron commented 5 years ago

@JonasWho if you take a peek at #54 you can get the backstory, but the tl;dr is I was not able to manually QA test the Android PR and haven't had anyone step up to help out. The android code in this repo was written by someone else which means I'm not super comfortable with it, and making changes to it. That combined with a lack of automated tests and my unfamiliarity using RN on Android, here we are.

JonasWho commented 5 years ago

@jordanbyron ok, that's fair. I would love to help, but also do not have the capabilities unfortunately :(