Added macOS support - Githubissues

jordanebelanger / SwiftyBluetooth

Closures based APIs for CoreBluetooth

MIT License

209 stars 66 forks source link

Added macOS support #24

Closed petroladkin closed 7 years ago

petroladkin commented 7 years ago

added macOS project
added #if/#else/#endif for the difference between iOS and macOS

jakerockland commented 7 years ago

@petroladkin Is this at a point where it is testable? I may not have a chance to look at it soon but very much would like having macOS support and happy to test and contribute!

petroladkin commented 7 years ago

@jakerockland the last pull request compiled for macOS but doesn't correctly work in some use cases. Now I testing SwiftyBluetooth in our App (commercial and not open source) on macOS and added small features and fixed one bug/crash. In some days I will create a new pull request with fixes.

jordanebelanger commented 7 years ago

So, I see at least 3 separate things you are doing right now:

Mac support
Running bluetooth tasks on a background queue
Cosmetic API changes

I don't have the time to review, test and integrate a branch that implements that many things at once.

Break them apart into their own separate branch otherwise I won't bother.

petroladkin commented 7 years ago

I close this pull request because I will create separated branches for pulls:

mac support
support custom work queue
cosmetic API changes In my main branch, I will want to apply from separated branches for supporting all features in our project over CocoaPods

jordanebelanger commented 7 years ago

Excellent, thank you for your interested in the library.