search

jordanebelanger / SwiftyBluetooth

Closures based APIs for CoreBluetooth
MIT License
209 stars 66 forks source link

Add Swift Package Manager Support #44

Closed levi closed 4 years ago

levi commented 4 years ago

Moves source files into Sources directory at the root of the project and introduces a Package.swift manifest file for Swift Package Manager to manage the framework as a dependency.

jordanebelanger commented 4 years ago

nice

jordanebelanger commented 4 years ago

@levi Seems like a .ds_store file was added by accident. Could you update the .gitignore file to ignore those and delete the one that was added please.

jordanebelanger commented 4 years ago

I don't have much time to test this, but since this is just moving files around a bit, could you confirm that you did some testing to see if using the library with cocoapods still works fine? @levi

levi commented 4 years ago

@jordanebelanger do you have an example app handy I can use to test?

jordanebelanger commented 4 years ago

I'm afraid not, I really haven't had much time to work on this recently. Perhaps just a quick single view application with a podfile that has this library rigged to use this PR branch. Just gotta make sure that the SwiftyBluetooth target imports correctly with Cocoapods and SPM and that you can call the functions as per usual, i.e just one successful attempt at calling say, scan for devices, should be enough to confirm.

jordanebelanger commented 4 years ago

@levi Just tested with a quick mac app with cocoapods, seemed to work good.

levi commented 4 years ago

Great, thanks for doing that!