search

jordaneremieff / mangum

AWS Lambda support for ASGI applications
https://mangum.io/
MIT License
1.67k stars 119 forks source link

Allow base path config for ALB handler #291

Open nipun-AiR opened 1 year ago

nipun-AiR commented 1 year ago

Closes #238

jordaneremieff commented 1 year ago

@nipun-AiR can you resolve the test coverage issues blocking the GH workflow from completing? I think okay to do # pragma: nocover if it's just the warning missing coverage.

I think this should be good to merge once passing the GH workflow.

nipun-AiR commented 1 year ago

@jordaneremieff Thanks for the comment - added test coverage for the missing lines.

jordaneremieff commented 1 year ago

@nipun-AiR looks like tests are passing now but need to apply linting/formatting before merge.