jordangarcia / nuclear-js-react-addons

NuclearJS addons for working with React
MIT License
20 stars 12 forks source link

Remove unnecessary files from NPM published package #18

Closed raulmatei closed 8 years ago

raulmatei commented 8 years ago

We've tried to use NuclearJS with React Native, but we've got into this issue: image

The best way would be to add a "files" property into package.json:

{
  "files": ["build", "dist"]
}

This way you'll end up with a clean package. I feel that there's no need to have the sources published on NPM or am I wrong?

I can submit a PR if you can help me with the files list that you want to get into the published package.

Raul.

jordangarcia commented 8 years ago

feel free to PR and I will publish a new version

raulmatei commented 8 years ago

19 is up, feel free to add more files into that list, if needed.

Thanks, Raul.

jordangarcia commented 8 years ago

@raulmatei I published 0.4.1 with these changes, let me know if that solves your problems

raulmatei commented 8 years ago

Thanks @jordangarcia, it's fine on our side. Hope no one imported something directly from src directory which is excluded.