search

jordangarcia / nuclear-js-react-addons

NuclearJS addons for working with React
MIT License
20 stars 12 forks source link

Use prop-types package instead of React.PropTypes #23

Open jmschlmrs opened 7 years ago

jmschlmrs commented 7 years ago

Trying to resolve #22 in preparation for react v16.

Had to bump react to v0.14.9 for compatibility with the prop-types package, see https://github.com/facebook/prop-types#compatibility.

acr13 commented 7 years ago

Can't upvote this enough! Would it be possible to merge this in @jordangarcia ?

jmschlmrs commented 6 years ago

Note, we are now using a fork with React 16 support until this PR is merged: https://www.npmjs.com/package/nuclear-js-react-addons-chefsplate

acr13 commented 6 years ago

@jmschlmrs good idea - will use that fork for now