search

jordanisaacs / neovim-flake

Nix flake for neovim with configuration
https://jordanisaacs.github.io/neovim-flake
MIT License
246 stars 54 forks source link

Dracula theme #34

Closed MonaMayrhofer closed 1 year ago

MonaMayrhofer commented 1 year ago

This adds support for https://github.com/Mofiqul/dracula.nvim and https://github.com/dracula/vim that are afaik the two most popular implementations of the Dracula Theme

Annoyingly they are different in a few regards and if you are used to one switching to the other is a little hassle - so i propose to support them both.

Mofiqul image

Official image

jordanisaacs commented 1 year ago

Thanks for the PR, lgtm except for a small nit!

For the commit messages I have three comments:

  1. Can you update them to be Themes: Add XXX.
  2. Reference the updating plugin tracking issue in each commit message description (use #33)
  3. Add a comment in the release doc. Feel free to link to your github profile.

I listed this all and more in the contributing.md which I just wrote so you and others can reference for any future commits.

MonaMayrhofer commented 1 year ago

Should be tidied up now!

jordanisaacs commented 1 year ago

Thanks! Could you address that one comment about "dracula-nvim" naming and then its good to merge.

MonaMayrhofer commented 1 year ago

Wait err i think i missed something - which comment are you referring to? :eyes:

jordanisaacs commented 1 year ago

Hmm, should be a line comment. https://github.com/jordanisaacs/neovim-flake/pull/34#discussion_r1157867443

jordanisaacs commented 1 year ago

Ah I'm sorry. Still trying to figure out github's review UI which is very confusing. Didn't realize I had to not just add a comment but press the submit review in the corner. 🤷

MonaMayrhofer commented 1 year ago

I'm glad it wasn't just me who was blind :P