Closed jordanpartridge closed 5 months ago
:x: The following configuration files differ from the Laravel defaults. If you are modifying configuration values directly, consider using an environment variable instead to keep these files maintainable. You should compare your configuration files against the latest version and merge any updates.
:information_source: Starting with Laravel 8, the model
property within factories may be removed when your models are stored within a conventional location such as app/Models
. Unless your factory is for a model outside of this location, you may remove this property.
:warning: The following controllers contain actions outside of the 7 resource actions (index
, create
, store
, show
, edit
, update
, destroy
). For more details, review the docs or watch Cruddy by Design to see if you may rework these into resource controllers.
:warning: Shift detected the following HTTP components accessing the authenticated user through Auth::user()
. Within these components, you may access the authenticated user through the request object as well. Doing so limits your dependencies by leveraging objects already available.
:warning: Laravel contains many built-in helpers functions which allow you to write more expressive code or leverage core functionality from anywhere in your app.
Shift found the following code which could use a helper instead:
Redirect::to()
:x: Laravel 9.0 moved the resources/lang
folder to a top-level lang
folder. While Laravel allows the old folder, future versions may not. You should migrate this folder and add any new files.
:information_source: Shift detected your database migrations are using custom classes. Starting with Laravel 9.0, database migrations now use anonymous classes. This avoids class name collisions and streamlines migrations.
:information_source: As noted, much of the lint detected above can be automatically fixed using the Laravel Fixer. Save yourself time and clean up your codebase quickly with this new Shift.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the
shift-118669
branch.Before merging, you need to:
shift-118669
branchMuch of the lint detected may be automatically fixed by running the Laravel Fixer or tasks within the Shift Workbench.
Summary by CodeRabbit