search

jordanpotti / CloudScraper

CloudScraper: Tool to enumerate targets in search of cloud resources. S3 Buckets, Azure Blobs, Digital Ocean Storage Space.
MIT License
501 stars 108 forks source link

Refractoring #4

Closed melardev closed 5 years ago

melardev commented 6 years ago
  1. Checking if http occurrence is present in the whole URL string may lead to bugs if any URL contains, for any reason, the occurrence somewhere else apart from the protocol.
  2. Refractored the regex to check for http and https in one single place.
  3. Added the script tag search for retrieving further urls, there are other HTML tags of interest, for this Pull request I added the script which is used widely.
melardev commented 6 years ago

Added the multithreading feature(consumer/producer pattern), added verbose feature, refractored some code, updated the ArgumentParser: now it is exclusive, either -u to provide a url or a -l to provide a file for list of targets, I then realised that this may not be the intended functionality because you may want to allow a user to set -u and at the same time set -l, so if you want to support that functionality make sure to discard the changes of the Argparser Exclusive group commit(commit id: caf8ec8)

jordanpotti commented 5 years ago

Too many conflicts since code refactoring and new features were added just prior to this one.