search

jordansissel / eventmachine-tail

Ruby EventMachine file tailing and friends. 'gem install eventmachine-tail' to install.
127 stars 16 forks source link

Support for encodings in Ruby 1.9 #9

Closed iconara closed 13 years ago

iconara commented 13 years ago

Because FileTail uses File#sysread to read data the encoding gets set to ASCII-8BIT in Ruby 1.9. I've added a line that forces the encoding to the default external (the encoding the string would have gotten if it was read with File#read).

Tests pass in 1.8.7-p302 and 1.9.2-p0.

Btw. this patch does not depend on anything besides your current master. I still think you should fix your gemspec file as per the pull request from gaiottino though -- having a version number that changes every time you build the gem is a really bad idea in the age of Bundler.

jordansissel commented 13 years ago

I'll check out the patches tomorrow and push a new version if all looks good. Thanks for this :)

Re: bundler+versioning - You shouldn't be building/taking packages from this git repo. rubygems.org is the canonical place to find releases of this gem (I make no guarantees about the quality of the master branch at any given instant)

jordansissel commented 13 years ago

oh I see, people fork, patch, and build from their forks. I guess that seems reasonable, but you could just as easily patch the gemspec? I'll think about how to properly fix it tomorrow while I review the patches here.

iconara commented 13 years ago

It's a hassle to keep a patched gemspec in our own repository, it's very easy that it ends up in a patch. It would be better if the canonical gemspec was useable with Bundler.