search

jordansissel / heroku-buildpack-meteor

a heroku buildpack for meteor (meteor.com)
588 stars 264 forks source link

Add PhantomJS to make "spiderable" package working #12

Open camilleroux opened 11 years ago

barnett commented 10 years ago

@camilleroux, how did you get spiderable to work on heroku buildpack?

wfleming commented 9 years ago

@camilleroux Is this something you're still interested in?

phantomjs is packaged within Meteor (it is now: no idea if it was 2 years ago), but it ends up at a pretty wacky path. For current versions built with this buildpack, it's at .meteor_tool/packages/meteor-tool/.1.0.38.ieqxkv++os.linux.x86_64+web.browser+web.cordova/meteor-tool-os.linux.x86_64/d ev_bundle/lib/node_modules/phantomjs/lib/phantom/bin/phantomjs.

I've poked at meteor's internal directory a bit, & can't find any good version-independent symlinks to use in a PATH, so I'm leery of trying to make this available as part of the buildpack's standard behavior. I think you could use this if you wanted to, though, by modifying your process.env.PATH within your app during startup.

Alternatively, Meteorpedia suggests using the phantomjs smart package, which is probably a more more elegant solution.

lirbank commented 9 years ago

This buildpack has phantomJS by default https://github.com/AdmitHub/meteor-buildpack-horse

callmephilip commented 8 years ago

PR submitted https://github.com/jordansissel/heroku-buildpack-meteor/pull/42