search

jordansissel / pleaserun

An attempt to abstract this "init" script madness.
Other
1.17k stars 80 forks source link

Remove dependency on Ohai #74

Closed jordansissel closed 9 years ago

jordansissel commented 9 years ago

Platform detection is nice, but Ohai requires Ruby C extensions which don't work under JRuby.

jordansissel commented 9 years ago

Done in 7f53321 - ohai is now optional.

igalic commented 9 years ago

what about facter?

jordansissel commented 9 years ago

@igalic I haven't tested yet. Could you see if there's any C-extension dependencies of facter?

igalic commented 9 years ago

created a gemfile:

source ENV['GEM_SOURCE'] || "https://rubygems.org"

gem 'facter', ">= 1.0.0"

and ran bundle, this is the resulting Gemfile.lock

GEM
  remote: https://rubygems.org/
  specs:
    CFPropertyList (2.2.8)
    facter (2.4.1)
      CFPropertyList (~> 2.2.6)

PLATFORMS
  ruby

DEPENDENCIES
  facter (>= 1.0.0)

on debuntu, facter depends on stuff like

Depends: ruby | ruby-interpreter, virt-what, pciutils

to be able to do deeper introspection of the hardware (and tell if its running in a virtual machine, etc..)

jordansissel commented 9 years ago

@igalic I'm open to adding facter, though the nice puppet folks are working on implementing parts of facter in C, which makes that pure-rubyness go away a bit. Ahh well... Possible we can improve and implement just OS detection parts in pleaserun w/ the old parts of facter?

jordansissel commented 9 years ago

7f53321f removed ohai as a required dependency.