search

jordansissel / ruby-cabin

Structured+contextual logging experiments in Ruby
Other
153 stars 22 forks source link

Tiny cleanups #29

Closed rud closed 5 years ago

rud commented 9 years ago

Markup the README with ruby and json code-highlighting.

Trying to fix the build on Travis, but it seems Ruby 1.8 has some unstable ideas about the order of data read from multiple pipes, results at https://travis-ci.org/rud/ruby-cabin/builds. Knowing this, maybe the test should be relaxed to only assert on the contents of the log, not the exact ordering. Thoughts on this?

rud commented 9 years ago

Alright, there I fixed it in https://github.com/rud/ruby-cabin/commit/928fed2a8111ed075195077976101d6df3071b70 - any thoughts on this approach? As the build is all green again, this might make it possible to reinstate Travis or another CI.

rud commented 9 years ago

If any of this is seen as controversial I'll be happy to change it. Just thought it would be a nice few things to clean up. Feedback most welcome.

rud commented 9 years ago

Aaw, noone around to merge this?