jordansissel / ruby-cabin

Structured+contextual logging experiments in Ruby
Other
153 stars 22 forks source link

Missing 0.9.0 tag #51

Open Apteryks opened 1 year ago

Apteryks commented 1 year ago

Hi,

It seems the 0.9.0 release available as a gem hasn't been tagged; would it be possible to do so?

Thank you!

ph commented 1 year ago

Hey @Apteryks

I've access to this repository but I do not have access to the published gems, not sure I had I ever had it.. Looking at the current master version 0.8.1 and the released version on rubygems the code is diverging. I took the liberty of comparing the two code base. (diff -crB ruby-cabin cabin-0.9.0 > 8.0.1-to-0.9.0.diff)

@jsvd I believe you were the last one publishing the 0.9.0 version... I believe the change were never made into a PR. If you don't have the change locally, maybe the best route is to apply the patch below and make a 0.9.1 release? I can create a PR but I would either need you or @jordansissel to release it.

@Apteryks pardon my curiosity, but I believe you are trying to package this library for Guix (. I am curious which application is using this dependency?

Only in ruby-cabin: cabin.gemspec
Only in ruby-cabin: CONTRIBUTORS
Only in ruby-cabin: Gemfile
Only in ruby-cabin: Gemfile.lock
Only in ruby-cabin: .git
Only in ruby-cabin: .gitignore
diff '--color=auto' -crB ruby-cabin/lib/cabin/mixins/logger.rb cabin-0.9.0/lib/cabin/mixins/logger.rb
*** ruby-cabin/lib/cabin/mixins/logger.rb   2023-03-12 13:42:19.135748721 -0400
--- cabin-0.9.0/lib/cabin/mixins/logger.rb  2023-03-12 13:41:55.335594225 -0400
***************
*** 20,27 ****
      :error => 1,
      :warn => 2,
      :info => 3,
!     :debug => 4,
!     :trace => 5
    }

    BACKTRACE_RE = /([^:]+):([0-9]+)(?::in `(.*)')?/
--- 20,26 ----
      :error => 1,
      :warn => 2,
      :info => 3,
!     :debug => 4
    }

    BACKTRACE_RE = /([^:]+):([0-9]+)(?::in `(.*)')?/
***************
*** 38,51 ****
    # Each level-based method accepts both a message and a hash data.
    #
    # This will define methods such as 'fatal' and 'fatal?' for each
!   # of: fatal, error, warn, info, debug, trace
    #
    # The first method type (ie Cabin::Channel#fatal) is what logs, and it takes a
    # message and an optional Hash with context.
    #
    # The second method type (ie; Cabin::Channel#fatal?) returns true if
    # fatal logs are being emitted, false otherwise.
!   LEVELS.keys.each do |level|
      predicate = "#{level}?".to_sym

      # def info, def warn, etc...
--- 37,51 ----
    # Each level-based method accepts both a message and a hash data.
    #
    # This will define methods such as 'fatal' and 'fatal?' for each
!   # of: fatal, error, warn, info, debug
    #
    # The first method type (ie Cabin::Channel#fatal) is what logs, and it takes a
    # message and an optional Hash with context.
    #
    # The second method type (ie; Cabin::Channel#fatal?) returns true if
    # fatal logs are being emitted, false otherwise.
!   %w(fatal error warn info debug).each do |level|
!     level = level.to_sym
      predicate = "#{level}?".to_sym

      # def info, def warn, etc...
Only in ruby-cabin: Makefile
Only in ruby-cabin: notify-failure.sh
Only in ruby-cabin: Rakefile
Only in ruby-cabin: README.md
Only in ruby-cabin: sample.rb
diff '--color=auto' -crB ruby-cabin/test/cabin/test_logging.rb cabin-0.9.0/test/cabin/test_logging.rb
*** ruby-cabin/test/cabin/test_logging.rb   2023-03-12 13:42:19.135748721 -0400
--- cabin-0.9.0/test/cabin/test_logging.rb  2023-03-12 13:41:55.335594225 -0400
***************
*** 67,73 ****
      sub2 = Receiver.new
      @logger.subscribe(sub1, :level => :info)
      @logger.subscribe(sub2, :level => :error)
-     @logger.trace("test trace")
      @logger.debug("test debug")
      @logger.info("test info")
      @logger.error("test error")
--- 67,72 ----
diff '--color=auto' -crB ruby-cabin/test/test_helper.rb cabin-0.9.0/test/test_helper.rb
*** ruby-cabin/test/test_helper.rb  2023-03-12 13:42:19.135748721 -0400
--- cabin-0.9.0/test/test_helper.rb 2023-03-12 13:41:55.335594225 -0400
***************
*** 3,5 ****
--- 3,8 ----
  require "minitest/autorun"
  require "cabin"
  require "stringio"
+ require "simplecov"
+ 
+ SimpleCov.start
Only in ruby-cabin: .travis.yml
Apteryks commented 1 year ago

Thanks for the diff! The changes are not too worrying, but it'd be nice to have a tag in sync with the released gem.

I'm packaging this for Guix because it's needed by fpm.