jordansissel / ruby-ftw

Ruby FTW - For The Web. Experimentation in web clients and servers.
31 stars 18 forks source link

Bump addressable to 2-4 min #43

Closed mindbat closed 5 years ago

mindbat commented 5 years ago

Should fix #42

Bumps the addressable dependency to >= 2.4. This should make us compatible with logstash (and logstash plugins) for 7.x and up.

Passes tests locally (after some fudging with the documentation of methods and constants, which is beyond the scope of this patch):

mindbat-pro-elastic:ruby-ftw rontoland$ make test
sh notify-failure.sh ruby test/all.rb
Loading tests from test/docs.rb
Loading tests from test/ftw/crlf.rb
Loading tests from test/ftw/singleton.rb
Loading tests from test/ftw/http/headers.rb
Loading tests from test/ftw/http/dns.rb
Loading tests from test/ftw/protocol.rb
Coverage report generated for Unit Tests to /Users/rontoland/Code/ruby-ftw/coverage. 115 / 340 LOC (33.82%) covered.
Run options: --seed 2829

# Running:

[warn]: @param tag has unknown parameter name:  
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/agent.rb' near line 278
[warn]: @param tag has unknown parameter name: a 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/headers.rb' near line 24
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/headers.rb' near line 34
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/headers.rb' near line 34
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/message.rb' near line 38
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/message.rb' near line 46
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/http/message.rb' near line 46
[warn]: @param tag has unknown parameter name: the 
    in file `/Users/rontoland/Code/ruby-ftw/lib/ftw/websocket/parser.rb' near line 77
...............

Finished in 0.383353s, 39.1284 runs/s, 65.2140 assertions/s.

15 runs, 25 assertions, 0 failures, 0 errors, 0 skips
mindbat commented 5 years ago

@jordansissel What do you think of this issue/fix?

jordansissel commented 5 years ago

👍

jordansissel commented 5 years ago

ftw v0.0.49 published <3

mindbat commented 5 years ago

thanks, @jordansissel!