search

jordansissel / ruby-grok

Pure-ruby implementation of grok.
Apache License 2.0
54 stars 25 forks source link

close the file after reading the patterns #16

Closed ph closed 9 years ago

ph commented 9 years ago

Close the file after reading the patterns.

jsvd commented 9 years ago

For smallish files I usually prefer 

File.readlines("path").each do |line|
   process(line)
end

since it closes the file by itself, but otherwise LGTM

ph commented 9 years ago

@jordansissel can you merge this and release a new gem? I have already bumped the version in the gemspec.