jordansissel / xdotool

fake keyboard/mouse input, window management, and more
Other
3.26k stars 319 forks source link

xdo_get_active_modifiers disrupts the conventions of the library #3

Closed KoFish closed 9 years ago

KoFish commented 12 years ago

xdo_get_active_modifiers() returns a pointer to a struct instead of returning the values in arguments like all similar functions in the library does. By changing this there would be no need for the xdo_active_mods_t struct either.

jordansissel commented 9 years ago

The current method definition is this:

int xdo_get_active_modifiers(const xdo_t *xdo, charcodemap_t **keys, int *nkeys) {

I think 7cf1eaaf fixed this.

jordansissel commented 9 years ago

Closing since I think this was resolved in 7cf1eaaf; reopen if you feel otherwise :)