search

jordemort / action-pyright

A GitHub Action to run pyright
MIT License
11 stars 6 forks source link

test pyright ouput lines vs rdjson output #16

Closed chadsr closed 2 years ago

chadsr commented 2 years ago

I have been seeing some issues with the reviewdog annotation being displayed on the line below where it should be, so I started writing a test suite for the rdjson converter function.

So far the test is passing as expected, so this is a WIP whilst I figure out where the line mismatch might be coming from. (Either way, the script gets a test suite, even if the problem is in reviewdog/pyright itself!)

chadsr commented 2 years ago

Closes #15

jordemort commented 2 years ago

@Chadsr Is this one ready to go? If so, could you hit the "Ready for review" button? Thanks!

chadsr commented 2 years ago

@jordemort I was hoping to look further for this potential line offset issue, but i'm not sure if I have the time right now. So yeah, let's merge this and any fixes (if needed) can come along later.

jordemort commented 2 years ago

@Chadsr Upon review it looks like the linters are cranky about a few things; could you take a look at those annotations and appease it, or do you mind if I do it? I really should update the workflow so it does suggestions instead of just check failures. If you click over to the "Files changed" view you can see the things it is complaining about.

chadsr commented 2 years ago

@jordemort Shoud be fixed now!

jordemort commented 2 years ago

Sorry, dropped off the planet for a bit but I'm back