Action does not respect the reviewdog error level

jordemort / action-pyright

A GitHub Action to run pyright

MIT License

11 stars 6 forks source link

Action does not respect the reviewdog error level #31

Open justinchuby opened 2 years ago

justinchuby commented 2 years ago

The action produces error comments even when level: warning is set:

- name: pyright
  uses: jordemort/action-pyright@v1
  with:
    github_token: ${{ secrets.github_token }}
    reporter: github-pr-check
    level: warning
    filter_mode: diff_context
    lib: true

It would be great if the highest error level is reduced to the level specified in the action config.

jordemort commented 2 years ago

I think the level of the comments is based on the severity emitted by pyright, whereas the -level argument to reviewdog determines the overall status of the run. Is the job you're calling from the action returning an error status, or is it just the comments?

jordemort commented 2 years ago

Notes for when I loop back to fix this:

We can cap the severity here: https://github.com/jordemort/action-pyright/blob/main/pyright_to_rdjson/pyright_to_rdjson.py#L31=
But right now pyright_to_rdjson doesn't know about INPUT_LEVEL
- Either need to pass it as a CLI parameter here: https://github.com/jordemort/action-pyright/blob/main/script.sh#L69=
- Or just pull it out of os.environ

justinchuby commented 2 years ago

I think the level of the comments is based on the severity emitted by pyright, whereas the -level argument to reviewdog determines the overall status of the run. Is the job you're calling from the action returning an error status, or is it just the comments?

Both the job and the returned comments errored. It also for some reason stopped the job even though fail_on_error was not set