search

jordemort / action-pyright

A GitHub Action to run pyright
MIT License
11 stars 6 forks source link

pyright installation installs all node dependencies #33

Closed rnovacek closed 2 years ago

rnovacek commented 2 years ago

The action runs npm install pyright here (or similar when specific pyright version is specified). This means all node dependencies are installed as well if package.json exists in the repo as well. I don't think it's necessary and it slows down the check significantly.

It might be better to use npx/npm exec to install and run directly in one command.

jordemort commented 2 years ago

This is a good idea; I'll get around to implementing it eventually but would happily accept a pull request if you don't want to wait :)

jordemort commented 2 years ago

Implemented in https://github.com/jordemort/action-pyright/pull/34 - thanks for the idea!

rnovacek commented 2 years ago

Thank you for the improvement!