jordemort / docker-pleroma

Pleroma in a container
https://hub.docker.com/r/jordemort/pleroma
16 stars 1 forks source link

Soapbox support #1

Closed hlesesne closed 3 years ago

hlesesne commented 3 years ago

I modified the docker-compose example, as well as the Dockerfile to support the SoapBox UI.

The downside is another payload in the docker build and also, on entrypoint, if the zip archive of soapbox-fe.zip exists (and the environment variable USE_SOAPBOX is set to "y", it will extract the archive into the appropriate location. I don't like that this adds to start up time (and the size of the container), but I can think of a better way given that the static volume where soapbox resides needs to be mounted for most use cases (which would remove the soapbox changes).

I also versioned the docker-compose file. The format wasn't working, for me, on the latest version of docker-compose.

jordemort commented 3 years ago

Thanks!

I also versioned the docker-compose file. The format wasn't working, for me, on the latest version of docker-compose.

What version of docker-compose and Docker specifically? It's been my understanding that it's better to leave the version off since the "Compose Specification" merged versions 2 and 3. I've been leaving version off all year and it's been working everywhere I tried it.

See: https://docs.docker.com/compose/compose-file/compose-versioning/

jordemort commented 3 years ago

Would you mind adding a bit about USE_SOAPBOX (and maybe a link to to the Soapbox site) to the README?

hlesesne commented 3 years ago

What version of docker-compose and Docker specifically? It's been my understanding that it's better to leave the version off since the "Compose Specification" merged versions 2 and 3. I've been leaving version off all year and it's been working everywhere I tried it.

> docker --version
Docker version 19.03.12, build 48a66213fe
> docker-compose --version
docker-compose version 1.25.0, build unknown

There error that I get without it, doesn't seem to like the network and volume formats.

> docker-compose up --build
ERROR: The Compose file './docker-compose.yml' is invalid because:
Unsupported config option for volumes: 'config'
Unsupported config option for services: 'pleroma'
Unsupported config option for networks: 'pleromanet'

adding

version: '3.7'

seemed to fix it. Not sure why I chose 3.7 honestly :-). I'm totally good with pulling this one it. It likely works better that way for most.

hlesesne commented 3 years ago

I updated the Readme a little. I would have added it to the table of environment variables that you already had, but without an accompanying Pleroma argument, it didn't seem to make sense.

jordemort commented 3 years ago

docker-compose version 1.25.0, build unknown

Ah, yeah, looks like the "Compose Specification" stuff happened in 1.27.0.

hlesesne commented 3 years ago

I upgrade docker-compose and am in good shape now. Thanks!