search

jordens / pydc1394

python libdc1394 wrapper
GNU Lesser General Public License v3.0
3 stars 9 forks source link

Adding new image size (i.e. `mode`) #1

Open hamid-m opened 9 years ago

hamid-m commented 9 years ago

The Point Grey Chameleon camera (CMLN-13S2M-CS) I am using supports a resolution of 1296 x 964. This size is not defined as one of the available modes. Instead, the largest listed available mode is 1280 x 960, which if selected, causes the example code (examples/save_image.py) to fail. However, lower resolution does work (640 x 480).

Can the code be extended to handle the 1296 x 964 (Y8) option? I noticed a key mapping between mode names and integers are used. I wasn't sure if adding an entry (and thus changing indices) would break other features. If you can give me some guidance I'd be happy to put in a pull request.

And thank you for the great library.

hamid-m commented 9 years ago

Ok - an update. The save_image.py example from this repository seems to work fine. I guess the issue I described is true for another copy of pydc1394 here. Honestly, I'm unsure which of these three is the official repository for pydc1394:

  1. https://github.com/jordens/pydc1394 (right here - PyPi points here too)
  2. https://github.com/imrehg/pydc1394
  3. https://launchpad.net/pydc1394
jordens commented 9 years ago

This is open source. There is no official version ;)

Everything started on launchpad. Then I forked it because the API was a mess and I wanted to make non-backcompatible changes. https://github.com/imrehg/pydc1394 is a copy of the old (5 years since the last change) original launchpad tree https://launchpad.net/pydc1394. https://github.com/jordens/pydc1394 is the continuation of https://code.launchpad.net/~jordens/pydc1394/work which is my forked tree.

Yes. In general you can add your new mode to the code and I'd be glad to accept a patch. Take a look at https://github.com/jordens/pydc1394/blob/master/pydc1394/dc1394.py and http://damien.douxchamps.net/ieee1394/libdc1394/api/types/ to see whether it is already there (it needs to get to libdc1394 first) and where and how to add it.

jordens commented 9 years ago

On the other hand, what you probably want is Format7, see http://damien.douxchamps.net/ieee1394/libdc1394/api/format7/

jordens commented 6 years ago

Is this resolved?