updates project setup - Githubissues

jordibruin / Swift-Charts-Examples

An overview of the different types of charts you can make with Swift Charts

MIT License

2.04k stars 129 forks source link

updates project setup #2

Closed brennanMKE closed 2 years ago

brennanMKE commented 2 years ago

adds MIT LICENSE
adds Build.xcconfig for cross-platform development
adds workspace to better integrate with Swift packages
defines Template Macros for source file header
updates existing source files to use common header

jordibruin commented 2 years ago

Thanks for this @brennanMKE !

jordibruin commented 2 years ago

@brennanMKE can you fix the merge conflict? I don't really know what's going wrong 😜

jordibruin commented 2 years ago

Also, I noticed that you left your development team in your commit.

Also, I think Swift_Charts_ExamplesApp is better than ChartsApp, since it's a clearer explanation of what the project is.

brennanMKE commented 2 years ago

Also, I noticed that you left your development team in your commit.

Also, I think Swift_Charts_ExamplesApp is better than ChartsApp, since it's a clearer explanation of what the project is.

Ok. Just did not look right to me having underscores in the name.

brennanMKE commented 2 years ago

@jordibruin Just cleaned up the PR a bit. Had to update my Mac with some conveniences I had not put on here yet to help with staying in sync with the upstream. I pulled out the signing value for DEVELOPMENT_TEAM which only applies to me. I am not sure how to handle SWIFT_VERSION but it appears 5.7 is simply handled as Swift 5 by Xcode.

For releases what we could do is summarize all commits with each of the PRs which make up that release which would feature the developers who made contributions.