search

jordibruin / Swift-Charts-Examples

An overview of the different types of charts you can make with Swift Charts
MIT License
1.95k stars 126 forks source link

Adds Candle Stick Chart with Annotation to Bar Charts #63

Closed tommy-holmes closed 2 years ago

tommy-holmes commented 2 years ago

Hi, this repo is a great idea and I want to contribute my own chart to it which I think anyone planning on making a stocks app would find useful!

This PR will add a candle stick chart to the Bar Charts Folder. I made it and wrote a blog post a few days ago before coming across this repo and I think it will make a good addition (hopefully you'll agree :)).

Hopefully, I have followed the instructions you have laid out for adding a chart to the repo - but let me know if I have missed anything! Cheers :)

tommy-holmes commented 2 years ago

Overview

Simulator Screen Shot - iPhone 13 mini - 2022-06-23 at 17 37 34

Detail

Simulator Screen Shot - iPhone 13 mini - 2022-06-23 at 17 38 20

With overlay and annotation

Simulator Screen Shot - iPhone 13 mini - 2022-06-23 at 17 38 27

jordibruin commented 2 years ago

Wow this looks great!!! Will have a look at it later, maybe @atrinh0 or anyone else can have a look and see what could be added / improved 🙂

atrinh0 commented 2 years ago

These look great as is 🙌🏻, hope nobody minds me moving them to the range charts.

tommy-holmes commented 2 years ago

Cheers! Sounds good - that would make more sense 👍