search

jordigg / chocolatey-officebusiness

Chocolatey Office Business related packages
3 stars 16 forks source link

Dynamic product id and exclude apps #11

Closed ctr49 closed 4 years ago

ctr49 commented 4 years ago

Allow different product IDs and excluded apps.

Implements #9

Please test this and comment. I did not have the opportunity to test this with existing installs.

jordigg commented 4 years ago

Seems to work. I tried with existing install and clean. I haven't checked if you have for example the full suite installed if it will uninstall those that you set to exclude, I don't think it does but we can maybe achieve that later. For now will install the packages you specify.

I have sent a commit updating the deployment binary and the extension version. I sent this to your fork.

jordigg commented 4 years ago

I'm trying to submit my commit to this PR and is driving my crazy... do you know if I'm missing anything? Should it be merge on your fork first?

ctr49 commented 4 years ago

Yes I'd be willing to contribute regularly. I checked "allow edits by maintainers" which should allow you to make the edits in my fork (dynamic-productid branch!).

This change will become even more relevant when https://github.com/chocolatey/ChocolateyGUI/issues/545 has been merged, allowing to specify the introduced parameters even in the GUI.