jordillonch / CrudGeneratorBundle

This Symfony2 bundle aims to be the bundle that you are looking for create a nice CRUD with pagination, filter, translation and Twitter bootstrap 2.2.2 features.
MIT License
83 stars 36 forks source link

Interface changes in SensioGeneratorBundle break this bundle in 2.2.x #11

Closed smith981 closed 11 years ago

smith981 commented 11 years ago

When installing, I get

Runtime Notice: Declaration of JordiLlonch\Bundle\CrudGeneratorBundle\Command\JordiLlonchCrudCommand::getFormGenerator() should be compatible with Sensio\Bundle\GeneratorBundle\Command\GenerateDoctrineCrudCommand::getFormGenerator($bundle = NULL)

The issue is the below commit to SensioGeneratorBundle added the optional parameter ($bundle = null) in several methods.

You can see the Sensio commit that caused the issue.

This should be an easy fix. I'm not too familiar with Github yet or I'd submit a PR.

jordillonch commented 11 years ago

fix it