jordipons / musicnn

Pronounced as "musician", musicnn is a set of pre-trained deep convolutional neural networks for music audio tagging.
ISC License
599 stars 87 forks source link

Possible mistake in feature extraction? #2

Open theelk801 opened 5 years ago

theelk801 commented 5 years ago

https://github.com/jordipons/musicnn/blob/795f320cb8ce255830883edd1332771254aa0908/musicnn/extractor.py#L216

It looks like the variable backend is being created instead of penultimate but not being used. Is this intentional?

jordipons commented 5 years ago

I renamed all the variables before the release so that they are more readable -- and I missed this one. You are completely right! Thanks :)

The issue is fixed in the Github repository. However, I did not push the fix to PyPi. Let's keep this issue open until I also fix the PyPi version.

philtgun commented 4 years ago

Any news on the updating PyPi?

jordipons commented 4 years ago

I didn't update. I'll do so once I release the next version! Feel free to clone the Github repository.