jordonwow / bigdebuffs

https://www.curseforge.com/wow/addons/bigdebuffs
47 stars 87 forks source link

Buffs not showing with ElvUI player frame #781

Closed TheOmegaOne closed 1 month ago

TheOmegaOne commented 2 months ago

I've tried resetting my player frame to elv UI default to no success, also copying the settings from the elvui target & focus frames - which do work to no success. Turning off elv UI then big debuffs is working with the blizzard default player frame, so it's likely an interaction specifically with Elv UI which is no longer working.

TheOmegaOne commented 2 months ago
    if unit:match("player") then
    local elvUIFrame = _G["ElvUF_Player"]
    if elvUIFrame and elvUIFrame:IsVisible() and elvUIFrame.unit then
        if unitGUID == UnitGUID(elvUIFrame.unit) then
            return elvUIFrame
        end
    end
    end

I fixed it locally by adding this code inside the "if unit and (unit:match("party") or unit:match("player")) then" block - as this block seems to only be returning party frames despite also checking if the matched unit is the player.

dumbrellas commented 2 months ago

Thanks this worked for me as well

Zaoza7 commented 2 months ago

I'm pretty hopeless with codes. Where in the LUa file do I enter that code? And does it replace something or is it an addition?

Tenoke commented 1 month ago
    if unit:match("player") then
  local elvUIFrame = _G["ElvUF_Player"]
  if elvUIFrame and elvUIFrame:IsVisible() and elvUIFrame.unit then
      if unitGUID == UnitGUID(elvUIFrame.unit) then
          return elvUIFrame
      end
  end
    end

I fixed it locally by adding this code inside the "if unit and (unit:match("party") or unit:match("player")) then" block - as this block seems to only be returning party frames despite also checking if the matched unit is the player.

Is Bigdebufss no longer under development that we need to edit it manually? Can you send it as a PR if they accept them?

jordonwow commented 1 month ago

I added your patch, thanks for the report.