search

jordonwow / omnibar

https://www.curseforge.com/wow/addons/omnibar
26 stars 27 forks source link

Removing a couple more Mage spells #226

Closed citna closed 1 year ago

citna commented 1 year ago

Arcane Mage's Mass Invisibility and Frost Mage's Summon Water Elemental were also removed this patch. They aren't causing any LUA errors because they weren't completely removed from the database so it doesn't have to be fixed immediately.

citna commented 1 year ago

@jordonwow what is the correct way to have different durations in child spell IDs from the parent? I was originally copying what I saw as the correct format but it actually does not work currently. I tried moving duration in front of the parent ID but it didn't change anything. I think it's important and I know I could just remove the ID as a child but then there would be quite a few duplicate spells people would have to track.

Important spells with a child having a different duration than the parent would be Balance Druid Incarn, Shimmer/Blink, Paladin Wings, Smoke Bomb between Sub and Assa/Outlaw, etc.

I see starting in Omnibar.lua at Line 886 is "-- child doesn't have custom charges, use parent"