jordwest / news-feed-eradicator

A browser extension that deletes your news feed and replaces it with a nice quote
MIT License
1.22k stars 284 forks source link

Not working on facebook #218

Closed MohamedAliRashad closed 2 years ago

MohamedAliRashad commented 2 years ago

The extension stopped working on facebook for some reason

laleaton commented 2 years ago

same for me

walpolsh commented 2 years ago

yup!

jordwest commented 2 years ago

Hmm, it's still working for me, so it's possible FB is rolling out a change to different cohorts.

Can someone who's having this problem please run this in the browser console from the Facebook homepage:

document.querySelector("div[role='feed']") == null 

And let me know what it returns

pgduval commented 2 years ago

i'm having the issue. the line returns "true"

lukechadwick commented 2 years ago

Hmm, it's still working for me, so it's possible FB is rolling out a change to different cohorts.

Can someone who's having this problem please run this in the browser console from the Facebook homepage:

document.querySelector("div[role='feed']") == null 

And let me know what it returns

Returns true for me. Probably the class/attributes changed. [role="main"] should work as a selector instead.

image

Niirdla commented 2 years ago

The extension stopped working on facebook for some reason

same for me

jordwest commented 2 years ago

Ahh yep sounds like they've made some changes that haven't been pushed out to everyone yet.

[role="main"] would likely remove too many UI elements, here's where role="feed" appears on my FB relative to role="main", can you see any equivalent attribute we could use as a selector for that element?

Screen Shot 2022-09-27 at 12 11 13 pm

lukechadwick commented 2 years ago

Perhaps this image

This element contains all the news feed items so #ssrb_feed_start + div works. I believe it's the same element you are referencing but they've just removed the role attribute.

jordwest commented 2 years ago

Ah awesome find, yep that should do it. I've pushed the change to master, could you try this build and see if it fixes it on yours?

NewsFeedEradicator_v2.2.2-3-gcd47dcd.zip

Chrome: Install extension from file

Firefox: Screen Shot 2022-09-27 at 12 46 25 pm Screen Shot 2022-09-27 at 12 47 55 pm Screen Shot 2022-09-27 at 12 48 02 pm

lukechadwick commented 2 years ago

@jordwest yep that works fine. Thank you!

image

jordwest commented 2 years ago

Excellent, thanks for debugging this one with me! Will publish it to the addon stores shortly.