jordwest / news-feed-eradicator

A browser extension that deletes your news feed and replaces it with a nice quote
MIT License
1.22k stars 284 forks source link

Current lockfile is preventing dependencies to properly resolve #230

Closed nzawirski closed 2 years ago

nzawirski commented 2 years ago

Currently running npm i fails with this output

npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @rollup/plugin-commonjs@11.0.2
npm ERR! Found: rollup@2.2.0
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^2.2.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^1.20.0" from @rollup/plugin-commonjs@11.0.2
npm ERR! node_modules/@rollup/plugin-commonjs
npm ERR!   dev @rollup/plugin-commonjs@"^11.0.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: rollup@1.32.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@"^1.20.0" from @rollup/plugin-commonjs@11.0.2
npm ERR!   node_modules/@rollup/plugin-commonjs
npm ERR!     dev @rollup/plugin-commonjs@"^11.0.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/nikodem/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/nikodem/.npm/_logs/2022-10-24T20_50_01_658Z-debug-0.log

Running it with --force or --legacy-peer-deps installs the packages, but that does not fix the make build and make dev commands which try to run npm install without any flags.

Solution to this is just removing the lockfile and allowing npm i to bump the packages to the newest compatible versions. I tested it and the extension builds and works properly.

Was there a reason for having the package-lock.json in a state as it is currently? If not then i will submit a pr updating it.