search

joreilly / Confetti

KMP GraphQL based conference project with Jetpack Compose Android, Compose for Wear, Compose Multiplatform and SwiftUI iOS clients along with GraphQL backend.
Apache License 2.0
812 stars 95 forks source link

Add / Remove bookmarks on Wear #623

Open yschimke opened 1 year ago

yschimke commented 1 year ago

from session screen, or possibly session list (secondary actions?) edit bookmarks

oas004 commented 1 month ago

On the session list are you thinking to have like a toggle button on each item with the bookmark icon? Or did you have a different design in mind? :) I think now each session is a card. If we are going for from the session details would it be nice to just add a toggle button from horologist(https://github.com/google/horologist/blob/main/compose-material/src/main/java/com/google/android/horologist/compose/material/ToggleButton.kt) at the bottom? Wdyt? :)

yschimke commented 1 month ago

I'm not sure.

When material3 is ready (https://github.com/joreilly/Confetti/pull/1462), I wanted to add a SwipeToReveal below the Session Card.

https://github.com/joreilly/Confetti/pull/1462/files#diff-e2f98bf7298001f9ef471afe0237dec508d661ea195e0fd98eabba87d6c8286c

oas004 commented 1 month ago

Aha! Okay! Yeah I think adding a swipeToReveal could solve it quite nicely. When looking at it on the M2 version at least, I feel like adding a toggle might cramp things up a bit at least.