search

jorendorff / cell-gc

A very small GC in Rust, with a safe API
MIT License
61 stars 4 forks source link

Add editing support to the REPL, using the rustyline crate. #30

Open jimblandy opened 7 years ago

jimblandy commented 7 years ago

It's a little weird to have the lisp crate depend on rustyline, instead of just bin/lisp.rs, but I don't know how to arrange that.

fitzgen commented 7 years ago

There are no binary only dependencies, and the issue requesting it was closed :(

fitzgen commented 7 years ago

Seems like the next closest thing is an optional-but-on-by-default feature.

jimblandy commented 7 years ago

@fitzgen Okay, I've made it an optional feature. Haven't done this before, so if you have style suggestions, I'm all ears.

fitzgen commented 7 years ago

Just saw this comment, which seems like the best way to do this: https://github.com/rust-lang/cargo/issues/1982#issuecomment-319661478

Sorry for moving goal posts...

jimblandy commented 7 years ago

Oh, that makes total sense!