search

jorendorff / js-loaders

Pseudoimplementation of the proposed ES6 module loaders.
54 stars 7 forks source link

What options to pass to which hooks #34

Closed jorendorff closed 10 years ago

jorendorff commented 11 years ago

Should we pass type to the fetch hook? What about extra?

We should probably pass everything we've got to every hook ...and maybe even change how this stuff works a little bit so we don't have to create so many objects.

samth commented 11 years ago

On Thu, May 30, 2013 at 11:25 AM, Jason Orendorff notifications@github.com wrote:

We should probably pass everything we've got to every hook

Yes.

and maybe even change how this stuff works a little bit so we don't have to create so many objects.

Are we really worried about this much allocation?

Sam

jorendorff commented 11 years ago

I'm more worried that it's not a very idiomatic API. Objects that look similar turn out not to be the same object. It's confusing.

It's not awful, but maybe we can do better.

samth commented 11 years ago

As in, you'd expect mutating one to change the later ones?

On Thu, May 30, 2013 at 11:45 AM, Jason Orendorff notifications@github.comwrote:

I'm more worried that it's not a very idiomatic API. Objects that look similar turn out not to be the same object. It's confusing.

It's not awful, but maybe we can do better.

— Reply to this email directly or view it on GitHubhttps://github.com/jorendorff/js-loaders/issues/34#issuecomment-18689007 .

samth commented 10 years ago

This was all about bundling, and bundling is gone.