jorendorff / js-loaders

Pseudoimplementation of the proposed ES6 module loaders.
54 stars 7 forks source link

Import reject handler never run #79

Closed guybedford closed 10 years ago

guybedford commented 10 years ago

This doesn't seem to be supported for, say, a fetch reject:

  System.import('some/module').then(function(module) {
  }, function(err) {
    // never gets called, even for a fetch error
    console.log(err);
  });

This seems to be because the reject function in AsyncStartLoadPartwayThrough is never called.

This can be fixed by changing step 13 of AsyncStartLoadPartwayThrough from:

  resolve(linkSet.done);

to:

  linkSet.done.then(resolve, reject);
guybedford commented 10 years ago

My mistake - promises do resolve correctly in this way.