adding the copy link functionality

jorenvh / laravel-share

Optional package for Laravel to generate social share links.

MIT License

529 stars 88 forks source link

adding the copy link functionality #52

Closed reza-kharestani closed 4 years ago

reza-kharestani commented 4 years ago

this patch will add a copy link functionality to show the link in a box and also if the user clicks on it the link will be copied to his/her clipboard. I added a new copylink.js which is needed if the developer wants to use the copy to clipboard capabilities it will result in this:

jorenvh commented 4 years ago

Thank you for taking the time to create a PR, however I don't think it belongs in this package as it's basically just copying the current url.

reza-kharestani commented 4 years ago

it does not only copy this page's link, but I use this to show the shortened URL link from bitly.com We found out in our business that if we provide the shortened version of a link people will share it more often. but of course, it is your call Thanks

jorenvh commented 4 years ago

I get that, but that logic is not happening within the package, so it's value gets lost in that case. For now I think it's not the right time to bring it to this package. If more requests for this are made I might reconsider it.

Thank you for understanding, and thanks again for the PR.