Closed kabe2007 closed 9 months ago
Someone is attempting to deploy a commit to a Personal Account owned by @jorge-menjivar on Vercel.
@jorge-menjivar first needs to authorize it.
Thank you for this fix. It works great on npm. However, to support multiple package managers, like pnpm, which is the default used for our turborepo setup in the CI/CD pipeline, we must not use relative imports, as the locations of modules change with package managers (That's the reason why the CI / Build and Test check failed). See #92 for the fix that works with npm and pnpm.
Great, thanks! I am new to turborepo, so apologies for the partial fix!
As always, thanks for your great work.
From: Jorge Menjivar @.> Sent: Tuesday, November 21, 2023 10:59 PM To: jorge-menjivar/unSAGED @.> Cc: kabe2007 @.>; Author @.> Subject: Re: [jorge-menjivar/unSAGED] Fixed next-auth/react not found (PR #86)
Thank you for this fix. It works great on npm. However, to support multiple package managers, like pnpm, which is the default used for our turborepo setup in the CI/CD pipeline, we must not use relative imports, as the locations of modules change with package managers (That's the reason why the CI / Build and Test check failed). See #92 https://github.com/jorge-menjivar/unSAGED/pull/92 for the fix that works with npm and pnpm.
— Reply to this email directly, view it on GitHub https://github.com/jorge-menjivar/unSAGED/pull/86#issuecomment-1821767815 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEH777DPPI2T2M2ZGMBPQ3YFUP3HAVCNFSM6AAAAAA7UVXRWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRG43DOOBRGU . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AGEH776XTYDHVC2DVWALW7TYFUP3HA5CNFSM6AAAAAA7UVXRWGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMSX4IO.gif Message ID: @. @.> >
After the update, got an error given it did not find the module next-auth/react. Fixed in helpers.ts.