jorge07 / alpine-php

Multi Arch Alpine PHP Docker images. 5.6, 7{0,1,2,3,4}, 8.{1,2,3}
https://hub.docker.com/r/jorge07/alpine-php/
Apache License 2.0
129 stars 54 forks source link

Remove layers #20

Closed jorge07 closed 7 years ago

jorge07 commented 7 years ago
jorge07 commented 7 years ago

Ping @ismael-benitez @1ma

1ma commented 7 years ago

Why did you remove the Travis integration?

jorge07 commented 7 years ago

Not using it, not useful at all, thinking on alternatives.

1ma commented 7 years ago

Well, if you think about it Docker Hub is already a CI service for Docker images.

jorge07 commented 7 years ago

Not, it isn't. I'm currently thinking about tests the configuration, xdebug integration and a performance test. But I wanna keep the automated buildings in docker Hub. I'll moved into tag instead push soon.

1ma commented 7 years ago

Ah, I figured you only wanted to test that the images built fine.

I managed to do something similarish to that with Scrutinizer: https://github.com/1ma/RedisSessionHandler/blob/master/.scrutinizer.yml

Under override: you can execute arbitrary docker and docker-compose commands (in fact composer test does just that). You must first figure out how your testing environment will be and how you'll interact with it, though.

1ma commented 7 years ago

Staying on topic the PR looks fine, I just don't grok where these rootfs and devfs come from.

jorge07 commented 7 years ago

Rootfs it's the filesystem of the base Dockerfile. Devfs it's the filesystem of the development environment.

I do it like that to avoid have multiple COPY instructions, which means a layer per instruction.

I'm second hand, I found so much easier replicate the fs structure to edit the files I need inside the container.

So, basically the original filesystem it's the alpine one. Extended by Rootfs and in the development image extended by Devfs.

So that the reason behind.