jorge07 / alpine-php

Multi Arch Alpine PHP Docker images. 5.6, 7{0,1,2,3,4}, 8.{1,2,3}
https://hub.docker.com/r/jorge07/alpine-php/
Apache License 2.0
129 stars 54 forks source link

PHP 7.2 and 7.3 images fix/update #59

Closed kowalk closed 5 years ago

kowalk commented 5 years ago

@jorge07 affected with https://github.com/jorge07/symfony-4-es-cqrs-boilerplate/pull/112/

jorge07 commented 5 years ago

Great! I'll merge an create a release for this

jorge07 commented 5 years ago

I need to improve the tests there're false positives

jorge07 commented 5 years ago

docker exec php7.3 php -v PHP 7.2.18 (cli) (built: May 4 2019 16:25:12) ( NTS )

kowalk commented 5 years ago

docker exec php7.3 php -v PHP 7.2.18 (cli) (built: May 4 2019 16:25:12) ( NTS )

@jorge07 I've fixed that and added php version check to .travis.yml

kowalk commented 5 years ago

@jorge07 all checks are green now

jorge07 commented 5 years ago

That's a really great job @kowalk

jorge07 commented 5 years ago

I'm just created a release for: